hacky conditional scheduled tasks #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size differenceComparing this PR to
|
jmbrunskill
commented
Jul 4, 2024
| @@ -68,6 +72,17 @@ impl ScheduledNotificationPluginConfig { | |||
| // Then add the duration to the schedule_start_time until we're past now | |||
|
|
|||
| match self.schedule_frequency.as_str() { | |||
| "hourly" => { | |||
There was a problem hiding this comment.
Sounds like the use case we're looking at first will be daily backups. So we could drop hourly if we think it could cause problems..
|
In the realm of hacky solutions, in theory couldn't we put a conditional on a recipients query so the notification only has recipients when it needs to be sent out? |
That is a nice hacky idea, might give it a try... |
|
@EthanMcQ-TMF in your opinion what would be needed to make it less hacky? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👩🏻💻 What does this PR do?
Allows the user to create a conditional notification trigger as part of the schedule using a tera template.
🧪 How has/should this change been tested?
Needs some more testing I think. if someone created a template that included false and true that would potentially be weird but also maybe that's just their fault.
💌 Any notes for the reviewer?
I think the big gap here is probably some kind of alert condition state that we need to store.
Otherwise we could just keep alerting on the same condition.
Should this be a different mechanism that just a tera template, is a specific query a better thing?
Maybe it should be a different notification type to the scheduled ones?