Dots #4
Open
Dots #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the dots module and Dots class Added the dots colors to the colors module Added a block for allocating a small dots picture
Fixed dots indentation Also replaced list comprehension with generator comprehension in __str__
Fixed bug in __str__ that was causing the rows to not have the correct offsets within self.data
Inlined calls to _getindex Added :ivar size to docstring
Added a method to Dots that prints a representation of the image to the command line, for debugging and previewing purposes.
Default fill is now dotcolors.BLANK, not colors.DOT_BLANK Updated docstrings to reflect previous changes Defaults are now accurate
Added spacing to dotcolors assignments, to make them more consistent with the rest of the project
Added missing whitespace after imports Added explicit `elif type(obj) == alphasign.dots.Dots` Added `return False` on an invlaid object type.
|
@Lucretiel my apologies for letting this sit so long. Are you still willing to work on this to get it merged? I've made some initial comments, but a rebase with squashing would make the review much easier. Please rebase and squash all minor commits. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the WRITE SMALL DOTS part of the protocol. This is all tested and working on my Alpha Big Dot sign.