arm64: dts: qcom: msm8939-huawei-rio: Add initial device tree #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzy-080408
force-pushed
the
msm8916/6.12.1
branch
3 times, most recently
from
c632d86 to
18cb6d5
Compare
TravMurav
reviewed
Dec 31, 2024
wonderfulShrineMaidenOfParadise
suggested changes
Jan 1, 2025
Signed-off-by: Zhiyuan Bai <[email protected]>
bzy-080408
force-pushed
the
msm8916/6.12.1
branch
from
18cb6d5 to
e0c862c
Compare
TravMurav
reviewed
Feb 9, 2025
| @@ -0,0 +1,328 @@ | |||
| // SPDX-License-Identifier: GPL-2.0-only | |||
There was a problem hiding this comment.
Commit message: the prefix is wrong, I'd also appreciate if you could fill in the message like it's done for other device introduction commits.
| // SPDX-License-Identifier: GPL-2.0-only | ||
|
|
||
| /* | ||
| *Copyright (c) 2024 Zhiyuan Bai<[email protected]> |
There was a problem hiding this comment.
nit
Suggested change
| *Copyright (c) 2024 Zhiyuan Bai<[email protected]> | |
| * Copyright (c) 2024 Zhiyuan Bai <[email protected]> |
Comment on lines
+132
to
+133
| }; | ||
| &blsp_i2c5 { |
There was a problem hiding this comment.
nit
Suggested change
| }; | |
| &blsp_i2c5 { | |
| }; | |
| &blsp_i2c5 { |
Comment on lines
+137
to
+139
| compatible = "cypress,tt21000"; | ||
|
|
||
| reg = <0x1c>; |
There was a problem hiding this comment.
Suggested change
| compatible = "cypress,tt21000"; | |
| reg = <0x1c>; | |
| compatible = "cypress,tt21000"; | |
| reg = <0x1c>; |
Comment on lines
+168
to
+202
| &mdss { | ||
| status = "okay"; | ||
| }; | ||
|
|
||
| &mdss_dsi0 { | ||
| pinctrl-0 = <&mdss_default>; | ||
| pinctrl-1 = <&mdss_sleep>; | ||
| pinctrl-names = "default", "sleep"; | ||
| status = "okay"; | ||
|
|
||
| panel@0 { | ||
| compatible = "huawei,rio-panel"; | ||
| reg = <0>; | ||
|
|
||
| vsp-supply = <®_lcd_pos>; | ||
| vsn-supply = <®_lcd_neg>; | ||
| reset-gpios = <&tlmm 25 GPIO_ACTIVE_LOW>; | ||
|
|
||
| port { | ||
| panel_in: endpoint { | ||
| remote-endpoint = <&mdss_dsi0_out>; | ||
| }; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| &mdss_dsi0_out { | ||
| data-lanes = <0 1 2 3>; | ||
| remote-endpoint = <&panel_in>; | ||
| }; | ||
|
|
||
| &mdss_dsi0_phy { | ||
| qcom,dsi-phy-regulator-ldo-mode; | ||
| status = "okay"; | ||
| }; |
There was a problem hiding this comment.
This is optional but if you split up display into a separate commit (i.e. like 3e3d375) then you can upstream most of the other changes already, which I'd greatly appreciate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully working yet.
Tested peripherals:
Untested peripherals:
TODO: