arm64: dts: qcom: msm8939-huawei-rio: Add initial device tree #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzy-080408
force-pushed
the
msm8916/6.12.1
branch
2 times, most recently
from
a7f93a3 to
c632d86
Compare
Signed-off-by: Zhiyuan Bai <[email protected]>
bzy-080408
force-pushed
the
msm8916/6.12.1
branch
from
c632d86 to
18cb6d5
Compare
Comment on lines
+14
to
+19
| qcom,msm-id = <239 0>; | ||
| qcom,board-id = | ||
| <8054 4>, <8055 4>, <8070 4>, <8071 4>, | ||
| <8086 4>, <8087 4>, <8102 4>, <8134 4>, | ||
| <8135 4>, <8118 4>; | ||
|
|
There was a problem hiding this comment.
Suggested change
| qcom,msm-id = <239 0>; | |
| qcom,board-id = | |
| <8054 4>, <8055 4>, <8070 4>, <8071 4>, | |
| <8086 4>, <8087 4>, <8102 4>, <8134 4>, | |
| <8135 4>, <8118 4>; |
We don't need this when using lk2nd/lk1st.
Comment on lines
+163
to
+166
| /* | ||
| * NOTE: vdd is not directly supplied by pm8916_l16, it seems to be a | ||
| * fixed regulator that is automatically enabled by pm8916_l16. | ||
| */ |
There was a problem hiding this comment.
Is it true or just copied from kiwi?
There was a problem hiding this comment.
copied from kiwi and it can be used
There was a problem hiding this comment.
How would you know? Is it TRUE?
Comment on lines
+364
to
+370
| mag_reset_default: mag-reset-default-state { | ||
| pins = "gpio36"; | ||
| function = "gpio"; | ||
| drive-strength = <2>; | ||
| bias-disable; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Unused for now.
| <8086 4>, <8087 4>, <8102 4>, <8134 4>, | ||
| <8135 4>, <8118 4>; | ||
|
|
||
| model = "Huawei Maimang 4"; |
There was a problem hiding this comment.
Suggested change
| model = "Huawei Maimang 4"; | |
| model = "Huawei G7 Plus / G8 / GX8 / Maimang 4"; |
TravMurav
reviewed
Dec 31, 2024
Comment on lines
+158
to
+159
| interrupt-parent = <&tlmm>; | ||
| interrupts = <13 IRQ_TYPE_EDGE_FALLING>; |
There was a problem hiding this comment.
Let's use interrupts-extended
There was a problem hiding this comment.
Suggested change
| interrupt-parent = <&tlmm>; | |
| interrupts = <13 IRQ_TYPE_EDGE_FALLING>; | |
| interrupts-extended = <&tlmm 13 IRQ_TYPE_EDGE_FALLING>; |
wonderfulShrineMaidenOfParadise
suggested changes
Jan 1, 2025
Comment on lines
+158
to
+159
| interrupt-parent = <&tlmm>; | ||
| interrupts = <13 IRQ_TYPE_EDGE_FALLING>; |
There was a problem hiding this comment.
Suggested change
| interrupt-parent = <&tlmm>; | |
| interrupts = <13 IRQ_TYPE_EDGE_FALLING>; | |
| interrupts-extended = <&tlmm 13 IRQ_TYPE_EDGE_FALLING>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully working yet.
Tested peripherals:
Untested peripherals:
TODO: