Lenovo Yoga Tab 3 10 LTE initial support #374
Conversation
exkc
force-pushed
the
wip/msm8916/6.10
branch
2 times, most recently
from
1282b83 to
a415df4
Compare
exkc
force-pushed
the
wip/msm8916/6.10
branch
5 times, most recently
from
78a214d to
0e8bcc8
Compare
exkc
changed the title
exkc
force-pushed
the
wip/msm8916/6.10
branch
2 times, most recently
from
c454705 to
00cb640
Compare
exkc
force-pushed
the
wip/msm8916/6.10
branch
from
00cb640 to
96910d4
Compare
exkc
force-pushed
the
wip/msm8916/6.10
branch
2 times, most recently
from
3c87b13 to
09297b5
Compare
|
6.11 should just work, if you can confirm that. |
exkc
force-pushed
the
wip/msm8916/6.10
branch
from
09297b5 to
9db112a
Compare
I think that's it.the only thing left is the usb and the other things that mainline don't have driver for as you know I was quite struggling to get the USB work (power out/mode switching/guest mode) |
|
This looks good, however few things still left:
|
|
oh wait i forgot the hall sensor |
exkc
force-pushed
the
wip/msm8916/6.10
branch
5 times, most recently
from
83dea42 to
582ebef
Compare
|
that really should be the final I guess.I will do a boot test |
|
|
|
closed bc of missclick |
| linux,code = <KEY_VOLUMEUP>; | ||
| }; | ||
|
|
||
| hall-sensor { |
There was a problem hiding this comment.
we usually separate the hall sensor to it's own device, also these names doesn't conform to the dt bindings (should start with button- or event-)
would you mind checking your dts with dtbs_check? I think it's make CHECK_DTBS=y W=1 qcom-msm8909-lenovo-lxf-p5100.dtb
There was a problem hiding this comment.
make ARCH=arm O=build/ CHECK_DTBS=y W=1 qcom-msm8909-lenovo-lxf-p5100.dtb
make[1]: Entering directory '/tmp/linux/build'
make[3]: *** No rule to make target 'arch/arm/boot/dts/qcom-msm8909-lenovo-lxf-p5100.dtb'. Stop.
make[2]: *** [/tmp/linux/Makefile:1399: qcom-msm8909-lenovo-lxf-p5100.dtb] Error 2
make[1]: *** [/tmp/linux/Makefile:224: __sub-make] Error 2
make[1]: Leaving directory '/tmp/linux/build'
make: *** [Makefile:224: __sub-make] Error 2
eh?
There was a problem hiding this comment.
perhaps add qcom/ to the dtb path, tho I thought it still uses flat scheme for arm32 even after the recent sorting refactor
There was a problem hiding this comment.
a.log
i run it at the latest changes
There was a problem hiding this comment.
do you have the latest version of dt-schema?
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
There was a problem hiding this comment.
i did paru -S python-dtschema-git not long b4 i run that
There was a problem hiding this comment.
cache-controller is in the recent dt-schema, I'm not sure why check crashes, it shouldn't...
There was a problem hiding this comment.
regardless of the bindings check, the node name here is still wrong.
| reg = <1>; | ||
| function = LED_FUNCTION_POWER; | ||
| led-max-microamp = <5000>; |
There was a problem hiding this comment.
I thought I saw a color prop here before? What does this led do even?
There was a problem hiding this comment.
I somehow revent some change during the rebase. I added those back i tink um i guess missed one
There was a problem hiding this comment.
What does this led do even?
it is notification / chagrining on stock android
it is at the same place at the power button so i added this line function = LED_FUNCTION_POWER;
There was a problem hiding this comment.
please use LED_FUNCTION_INDICATOR or LED_FUNCTION_STATUS for notification led so software can find it
There was a problem hiding this comment.
ah also it is a heatbeat led.there are so many function cramming to the one led function
also LED_FUNCTION_CHARGING is also a thing
exkc
force-pushed
the
wip/msm8916/6.10
branch
from
7536545 to
b029fdb
Compare
exkc
force-pushed
the
wip/msm8916/6.10
branch
from
b029fdb to
ad72dfe
Compare
exkc
force-pushed
the
wip/msm8916/6.10
branch
from
41fb4ce to
9b4943d
Compare
| linux,code = <KEY_VOLUMEUP>; | ||
| }; | ||
|
|
||
| hall-sensor { |
There was a problem hiding this comment.
regardless of the bindings check, the node name here is still wrong.
| }; | ||
| }; | ||
|
|
||
| magnetometer@c { |
There was a problem hiding this comment.
looking at this again, 0xc is before 0x68. Please sort those per unit address when it exists
exkc
force-pushed
the
wip/msm8916/6.10
branch
from
9b4943d to
1afb56a
Compare
| &pm8909_bms { | ||
| status = "okay"; | ||
| }; |
There was a problem hiding this comment.
arch/arm/boot/dts/qcom/qcom-msm8909-lenovo-lxf-p5100.dtb: vm-bms@4000: 'monitored-battery' is a required property
from schema $id: http://devicetree.org/schemas/power/supply/qcom,pm8916-bms-vm.yaml#
There was a problem hiding this comment.
| &pm8909_bms { | |
| status = "okay"; | |
| }; | |
| &pm8909_bms { | |
| monitored-battery = <&bat>; | |
| status = "okay"; | |
| }; |
Lenovo Yoga Tab 3 10 LTE is a tablet using the MSM8909 SoC released in 2016. Add a device tree for with initial support for: - GPIO keys - pm8909-vibrator - SDHCI (internal and external storage) - UART - WCNSS (WiFi/BT) - Regulators - Touchscreen - PWM panel backlight - Hall - Power LED - Framebuffer - USB (Dont Work) - Magnetometer Signed-off-by: Karl Chan <[email protected]>
exkc
force-pushed
the
wip/msm8916/6.10
branch
2 times, most recently
from
431fd50 to
b88d0fd
Compare
TravMurav
merged commit 191b461
into
msm8916-mainline:wip/msm8916/6.12-rc4
|
This is good now, thanks! Feel free to open a follow up with extra features or fixup commits later if you think the base dts needs to be changed |
No description provided.