Added support for mrn to cmo/dmp patient id mapping #1015
Conversation
| } | ||
|
|
||
| /** | ||
| * Returns a list of mrn-dmp-cmo patient id triplets given a list of MRNs. |
There was a problem hiding this comment.
To confirm my understanding, technically this REST endpoint will return the triplets given not just MRNs but also DMP IDs and/or CMO Patient IDs, correct? If so, should we update the description to reflect that?
There was a problem hiding this comment.
Yeah, thats what I mean my mrn-dmp-cmo - thats the triplet. The class is called CrdbCrosswalkTriplet too.
| @Query(value = "SELECT CMO_ID, DMP_ID, PT_MRN " | ||
| + "FROM CRDB_CMO_DMP_MAP WHERE :inputId IN (DMP_ID, PT_MRN, CMO_ID)", | ||
| nativeQuery = true) | ||
| Object getCrdbCrosswalkTripletByInputId(@Param("inputId") String inputId); |
There was a problem hiding this comment.
Am I understanding it correctly that the CMO-DMP-MRN mapping already exists inside CRDB, and that you just wrote a new query in order to get the triplets?
There was a problem hiding this comment.
Yes, there is a crosswalk table in CRDB with this triplet info.
There was a problem hiding this comment.
Is it possible to spin up a local Swagger REST service for testing?
There was a problem hiding this comment.
Yes, follow the command line instruction below to pull this PR to your local machine, then you can compile/deploy locally
There was a problem hiding this comment.
Note, I noticed the tests failed, but thats just checkstyle. I will fix them, but the code works.
There was a problem hiding this comment.
I'm on a call now, but I can help at 12. I also just amended the PR to address the checkstyle issue
n1zea144
force-pushed
the
master
branch
2 times, most recently
from
b7096c0 to
bd1ccd8
Compare
Maps a list of MRN to a list of dmp-cmo-mrn patient id triplets.