Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove undefined from options #165

Closed
wants to merge 1 commit into from
Closed

Conversation

t-bltg
Copy link

@t-bltg t-bltg commented Jul 31, 2017

The current solution: (builder.coffee l.98)

# Special case: no default options, no user options give [undefined]
if user_options.length==1 && user_options[0] == undefined
  user_options = []

for removing undefined has flaws: when directives.options is empty and user_options is not, then this lines yields

user_options = user_options.concat directives.option
# e.g. user_options = ['-shell-escape'] and directives.option = [undefined]
# results in user_options = ['--shell-escape', undefined] => undefined remains ...

as stated in #162

This is a fix based on filtering out any occurrence of undefined in the array user_options.

Copy link

@r-stein r-stein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@t-bltg t-bltg closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants