Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue #22 for Pytorch versions >= 1.3.0 #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aRI0U
Copy link

@aRI0U aRI0U commented May 24, 2020

I just commented one line in nonechucks/dataloader.py since it raised an exception with PyTorch >=1.3.0. Commenting this line seems to make the program work as expected.

I ran a few experiments to find out why that line was necessary in the code, but I did not find anything problematic with that new version so I did not do any additional changes. Please tell me if you remember why you wrote this specific line in your code.

I also wrote a few tests. It's not a lot but I added them anyway to the tests/ folder.

I ran all my experiments with PyTorch 1.5.0.

@ms-lilibeth
Copy link

@msamogh could you please check this pull request and merge the branch? your project is good, but that issue stops me from using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants