TEST: support ruby 3.3 NoMethodError message #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby 3.3 changes error messages especially for NoMethodError: ruby/ruby#6950 https://bugs.ruby-lang.org/issues/18285 Modify spec to support this new ruby 3.3 error messages. Closes ms-ati#105 .
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 94 94
=========================================
Hits 94 94 ☔ View full report in Codecov by Sentry. |
|
Sorry for the delay on this, I agree with this simple fix and will try to get a release out |
ms-ati
approved these changes
Jul 24, 2024
|
Thank you for merging this change!, and also thanks to @mtasaka for creating the PR! 😄 Actually if you don't think the release is necessary, I can create a PR to add to the changelog the info that now |
|
v1.4.1 has been released which includes Ruby 3.3 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby 3.3 changes error messages especially for NoMethodError: ruby/ruby#6950
https://bugs.ruby-lang.org/issues/18285
Modify spec to support this new ruby 3.3 error messages.
Closes #105 .