-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency flame to ~> 0.2.0 #32
Conversation
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
9ec92e4
to
49d6195
Compare
Livebook for testing: Mix.install(
[
:kino,
:flame,
{:flame_k8s_backend, github: "mruoss/flame_k8s_backend", ref: "renovate/flame-0.x"}
],
force: true
)
flame_k8s_backend_git_ref = "renovate/flame-0.x"
System.put_env("FLAME_K8S_BACKEND_GIT_REF", flame_k8s_backend_git_ref)
Kino.start_child!(
{FLAME.Pool,
name: :flame_test,
code_sync: [
verbose: true,
copy_paths: true,
sync_beams: [Path.join(System.tmp_dir!(), "livebook_runtime")]
],
min: 1,
max: 1,
max_concurrency: 10,
backend: FLAMEK8sBackend,
idle_shutdown_after: :timer.minutes(5),
log: :debug}
)
defmodule Foo do
def test(args), do: "works #{inspect(args)} #{node()}"
end
FLAME.call(:flame_test, fn -> Foo.test(1234) end) |
@@ -178,6 +178,17 @@ defmodule FLAMEK8sBackend.RunnerPodTemplate do | |||
do: [], | |||
else: object_references(parent_pod_manifest) | |||
|
|||
parent = FLAME.Parent.new(parent_ref, self(), FLAMEK8sBackend, runner_pod_name, "POD_IP") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrismccord
I had to add this hack in order to be able to test the Livebook integration. Maybe FLAME.Parent.new/5
could at some point allow to pass the backend_vrs
.
and while at it the variable could also be renamed to backend_version
so us normalo humans don't have to reverse engineer it 😜
Livebook integration works with the |
11e0a19
to
6acb29e
Compare
6acb29e
to
566bbba
Compare
This PR contains the following updates:
~> 0.1.8
->~> 0.2.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.