set RELEASE_COOKIE instead of RELEASE_SECRET on runner pod

mruoss · Oct 9, 2024 · 3a33f4b · 3a33f4b
1 parent 17a7b74
commit 3a33f4b
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 43 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 <!--------------------- Don't add new entries after this line --------------------->
 
+## [0.5.6] - 2024-10-09
+
+### Fixed
+
+- Set `RELEASE_COOKIE` instead of `RELEASE_SECRET`
+
 ## [0.5.5] - 2024-10-08
 
 ### Fixed

diff --git a/lib/flame_k8s_backend/runner_pod_template.ex b/lib/flame_k8s_backend/runner_pod_template.ex
@@ -293,7 +293,7 @@ defmodule FLAMEK8sBackend.RunnerPodTemplate do
               )
           ]
           |> put_new_env("PHX_SERVER", "false")
-          |> put_new_env("RELEASE_SECRET", Node.get_cookie())
+          |> put_new_env("RELEASE_COOKIE", Node.get_cookie())
           |> put_new_env("RELEASE_DISTRIBUTION", "name")
           |> put_new_env("RELEASE_NODE", "flame_runner@$(POD_IP)")
         end)

diff --git a/mix.exs b/mix.exs
@@ -1,7 +1,7 @@
 defmodule FlameK8sBackend.MixProject do
   use Mix.Project
   @source_url "https://github.com/mruoss/flame_k8s_backend"
-  @version "0.5.5"
+  @version "0.5.6"
 
   def project do
     [

diff --git a/test/integration/manifest.yaml b/test/integration/manifest.yaml
@@ -16,19 +16,19 @@ metadata:
   namespace: integration
   name: pod-mgr
 rules:
-- apiGroups: [""]
-  resources: ["pods"]
-  verbs: ["create", "get", "list", "delete", "patch"]
+  - apiGroups: [""]
+    resources: ["pods"]
+    verbs: ["create", "get", "list", "delete", "patch"]
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   name: integration-pod-mgr
   namespace: integration
 subjects:
-- kind: ServiceAccount
-  name: integration
-  namespace: integration
+  - kind: ServiceAccount
+    name: integration
+    namespace: integration
 roleRef:
   kind: Role
   name: pod-mgr
@@ -40,42 +40,47 @@ metadata:
   name: integration
   namespace: integration
   labels:
-    app:  flame_test
+    app: flame_test
 spec:
   serviceAccountName: integration
   containers:
-  - name: integration
-    image: flamek8sbackend:integration
-    command: ["sh", "-c"]
-    args: ["iex --name flame_test@$(POD_IP) --cookie nosecret -S mix run -e FlameK8sBackend.IntegrationTestRunner.run_flame"]
-    resources:
-      requests:
-        cpu: 300m
-        memory: 300Mi
-      limits:
-        cpu: 300m
-        memory: 300Mi
-    env:
-      - name: POD_NAME
-        valueFrom:
-          fieldRef:
-            apiVersion: v1
-            fieldPath: metadata.name
-      - name: POD_NAMESPACE
-        valueFrom:
-          fieldRef:
-            apiVersion: v1
-            fieldPath: metadata.namespace
-      - name: POD_IP
-        valueFrom:
-          fieldRef:
-            apiVersion: v1
-            fieldPath: status.podIP
-      - name: RELEASE_DISTRIBUTION
-        value: name
-      - name: RELEASE_NODE
-        value: flame_test@$(POD_IP)
-    ports:
-    - containerPort:  80
-      name: integration
+    - name: integration
+      image: flamek8sbackend:integration
+      command: ["sh", "-c"]
+      args:
+        [
+          "iex --name flame_test@$(POD_IP) --cookie $(RELEASE_COOKIE) -S mix run -e FlameK8sBackend.IntegrationTestRunner.run_flame",
+        ]
+      resources:
+        requests:
+          cpu: 300m
+          memory: 300Mi
+        limits:
+          cpu: 300m
+          memory: 300Mi
+      env:
+        - name: POD_NAME
+          valueFrom:
+            fieldRef:
+              apiVersion: v1
+              fieldPath: metadata.name
+        - name: POD_NAMESPACE
+          valueFrom:
+            fieldRef:
+              apiVersion: v1
+              fieldPath: metadata.namespace
+        - name: POD_IP
+          valueFrom:
+            fieldRef:
+              apiVersion: v1
+              fieldPath: status.podIP
+        - name: RELEASE_DISTRIBUTION
+          value: name
+        - name: RELEASE_NODE
+          value: flame_test@$(POD_IP)
+        - name: RELEASE_COOKIE
+          value: nosecret
+      ports:
+        - containerPort: 80
+          name: integration
   restartPolicy: Always