Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lfo timing #58

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Lfo timing #58

wants to merge 3 commits into from

Conversation

friedolino78
Copy link
Contributor

No description provided.

@fundamental
Copy link
Member

As per some other PRs the schema changes are larger than I'd expect. Also of note within the schema changes I can see some of the envelope default values have changed. That seems to smell of a possible bug to me.

I do like the general idea of lfo fade in/fade out as the delayed start LFO always felt somewhat jerky to me. Does the zyn/zyn side of this handle not starting the fade in until the delay time has elapsed? Also, how does the GUI look to you. I feel like with these additional knobs it might be looking somewhat claustrophobic.

@friedolino78
Copy link
Contributor Author

i am confused. if i see this right, this feature was already merged via PR48

@friedolino78 friedolino78 marked this pull request as draft August 29, 2021 19:34
@friedolino78
Copy link
Contributor Author

As per some other PRs the schema changes are larger than I'd expect. Also of note within the schema changes I can see some of the envelope default values have changed. That seems to smell of a possible bug to me.

I do like the general idea of lfo fade in/fade out as the delayed start LFO always felt somewhat jerky to me. Does the zyn/zyn side of this handle not starting the fade in until the delay time has elapsed? Also, how does the GUI look to you. I feel like with these additional knobs it might be looking somewhat claustrophobic.

yes. it makes me afraid of adding more features ;-)
no idea how to solve the screen space issue. maybe we should ask the GOF if there are design patterns for this problem.

@fundamental
Copy link
Member

No idea with the screen space issue. It's one reason I've been hesitant with features. The only major one I've tried to push for is the user visible scopes which does eat up a lot of screen space, but it's less interactive, so I guess I view it differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants