Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VisionCamera/VisionCameraProxy.h file not found #66

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

PStrakendal
Copy link
Contributor

In v4 of VisionCamera the public headers changed from

ios/Frame Processor/VisionCameraProxy.h

to

ios/FrameProcessors/VisionCameraProxyHolder.h

But this was not updated in vision-camera-resize-plugin.

There is an issue reported #65 that can be re-created if you install the pods with

USE_FRAMEWORKS=static pod install

and then a build.

With the changes in this PR, builds are successful and the example app has been successfully installed on an iPhone.

@mrousavy mrousavy merged commit ff3b6d2 into mrousavy:main Jun 8, 2024
4 checks passed
@mrousavy
Copy link
Owner

mrousavy commented Jun 8, 2024

nice, thank you!

@BoavistaLudwig
Copy link

Just wanting to let anyone know, I had a hard time receiving that updated version/fix by just installing the package and with @latest.

This command fixed it: yarn add mrousavy/vision-camera-resize-plugin#main

Dont know if this is on me or something else.

@PStrakendal
Copy link
Contributor Author

Just wanting to let anyone know, I had a hard time receiving that updated version/fix by just installing the package and with @latest.

This command fixed it: yarn add mrousavy/vision-camera-resize-plugin#main

Dont know if this is on me or something else.

The latest release is 3.1.0 and there has not been any new release made after this PR was merged to main. This is why you only get the fix when using the main branch instead of the latest version.

Here you can see the diff between version 3.1.0 and the current main:

v3.1.0...main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants