Fix: clear orientation listener on close #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kamiss7
approved these changes
Aug 18, 2024
mrousavy
requested changes
Aug 20, 2024
package/android/src/main/java/com/mrousavy/camera/core/OrientationManager.kt
Outdated
Show resolved
Hide resolved
package/android/src/main/java/com/mrousavy/camera/core/OrientationManager.kt
Outdated
Show resolved
Hide resolved
|
Thanks for handling the requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR cleans android orientation listener on camera session close.
If this is not done, the events are still fired and they accumulate until you kill the app.
Changes
Added a
clearListenersfunctions in the OrientationManager which is then called when CameraSession.close() is called.Tested on
Samsung Galaxy tab active4 pro. Android 14.
Related issues