feat: Rewrite Android C++ part (`VisionCameraProxy` + `JFrame`) #1661

mrousavy · 2023-07-21T15:54:39Z

What

Fully rewrite the native Android C++ implementation for the Worklets/Frame Processors Runtime
Replace JImageProxy with JFrame wrapper
Expose everything through VisionCameraProxy
Make Frame Processor Plugins object oriented and constructable (VisionCameraProxy.getFrameProcessorPlugin(..))
Optimize performance in a lot of places by using const references to avoid copies

Changes

Tested on

Related issues

vercel · 2023-07-21T15:54:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 21, 2023 10:12pm

github-actions · 2023-07-21T15:55:12Z

android/src/main/cpp/FrameProcessorPluginHostObject.cpp

+
+std::vector<jsi::PropNameID> FrameProcessorPluginHostObject::getPropertyNames(jsi::Runtime &runtime) {
+  std::vector<jsi::PropNameID> result;
+  result.push_back(jsi::PropNameID::forUtf8(runtime, std::string("call")));


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T15:55:12Z

android/src/main/cpp/FrameProcessorPluginHostObject.cpp

+  return jsi::Value::undefined();
+}
+
+} // namespace vision


[cpplint] _{reported by reviewdog 🐶}
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2023-07-21T15:55:12Z

android/src/main/cpp/FrameProcessorPluginHostObject.h

+using namespace facebook;
+
+class FrameProcessorPluginHostObject: public jsi::HostObject {
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class FrameProcessorPluginHostObject [whitespace/indent] [3]

github-actions · 2023-07-21T15:55:13Z

android/src/main/cpp/FrameProcessorPluginHostObject.h

+            _plugin(plugin) { }
+    ~FrameProcessorPluginHostObject() { }
+
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class FrameProcessorPluginHostObject [whitespace/indent] [3]

github-actions · 2023-07-21T15:55:13Z

android/src/main/cpp/FrameProcessorPluginHostObject.h

+    std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime& runtime) override;
+    jsi::Value get(jsi::Runtime& runtime, const jsi::PropNameID& name) override;
+
+private:


[cpplint] _{reported by reviewdog 🐶}
private: should be indented +1 space inside class FrameProcessorPluginHostObject [whitespace/indent] [3]

github-actions · 2023-07-21T15:55:15Z

android/src/main/cpp/VisionCameraProxy.h

+
+private:
+  std::shared_ptr<RNWorklet::JsiWorkletContext> _workletContext;
+  std::shared_ptr<react::CallInvoker> _callInvoker;


[cpplint] _{reported by reviewdog 🐶}
Add #include for shared_ptr<> [build/include_what_you_use] [4]

github-actions · 2023-07-21T15:55:15Z

android/src/main/cpp/VisionCameraProxy.h

+                        jni::alias_ref<JVisionCameraScheduler::javaobject> scheduler);
+};
+
+}


[cpplint] _{reported by reviewdog 🐶}
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2023-07-21T15:55:15Z

android/src/main/cpp/java-bindings/JFrameProcessor.h

+using namespace facebook;
+
+struct JFrameProcessor : public jni::HybridClass<JFrameProcessor> {
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside struct JFrameProcessor [whitespace/indent] [3]

github-actions · 2023-07-21T15:55:16Z

android/src/main/cpp/java-bindings/JFrameProcessor.h

+  explicit JFrameProcessor(std::shared_ptr<RNWorklet::JsiWorklet> worklet,
+                           std::shared_ptr<RNWorklet::JsiWorkletContext> context);
+
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside struct JFrameProcessor [whitespace/indent] [3]

github-actions · 2023-07-21T15:55:16Z

android/src/main/cpp/java-bindings/JFrameProcessor.h

+   */
+  void call(alias_ref<JFrame::javaobject> frame) const;
+
+private:


[cpplint] _{reported by reviewdog 🐶}
private: should be indented +1 space inside struct JFrameProcessor [whitespace/indent] [3]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

github-actions · 2023-07-21T21:08:25Z

android/src/main/cpp/VisionCameraProxy.cpp

+VisionCameraProxy::~VisionCameraProxy() {
+  __android_log_write(ANDROID_LOG_INFO, TAG, "Destroying Context...");
+  // Destroy ArrayBuffer cache for both the JS and the Worklet Runtime.
+	auto workletContext = _javaProxy->cthis()->getWorkletContext();


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:25Z

android/src/main/cpp/VisionCameraProxy.cpp

+    throw std::runtime_error("Unknown FrameProcessor.type passed! Received: " + frameProcessorType);
+  }
+
+	_javaProxy->cthis()->setFrameProcessor(viewTag, make_global(frameProcessor));


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:25Z

android/src/main/cpp/VisionCameraProxy.cpp

+}
+
+void VisionCameraProxy::removeFrameProcessor(int viewTag) {
+	_javaProxy->cthis()->removeFrameProcessor(viewTag);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:25Z

android/src/main/cpp/VisionCameraProxy.cpp

+
+
+void VisionCameraInstaller::install(jni::alias_ref<jni::JClass>,
+																		jni::alias_ref<JVisionCameraProxy::javaobject> proxy) {


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:26Z

android/src/main/cpp/VisionCameraProxy.cpp

+	_javaProxy->cthis()->removeFrameProcessor(viewTag);
+}
+
+jsi::Value VisionCameraProxy::getFrameProcessorPlugin(jsi::Runtime& runtime, std::string name, jsi::Value jsOptions) {


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:08:28Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+		scheduler->cthis()->dispatchAsync([f = std::move(f)](){
+			f();
+		});
+	};


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:28Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+			f();
+		});
+	};
+	_workletContext = std::make_shared<RNWorklet::JsiWorkletContext>("VisionCamera",


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:28Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+		});
+	};
+	_workletContext = std::make_shared<RNWorklet::JsiWorkletContext>("VisionCamera",
+																																	 runtime,


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:28Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+	};
+	_workletContext = std::make_shared<RNWorklet::JsiWorkletContext>("VisionCamera",
+																																	 runtime,
+																																	 runOnJS,


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:08:29Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+	_workletContext = std::make_shared<RNWorklet::JsiWorkletContext>("VisionCamera",
+																																	 runtime,
+																																	 runOnJS,
+																																	 runOnWorklet);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

android/src/main/cpp/java-bindings/JVisionCameraProxy.h|25| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|26| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|27| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|28| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|30| public: should be indented +1 space inside class JVisionCameraProxy [whitespace/indent] [3]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|31| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|33| private: should be indented +1 space inside class JVisionCameraProxy [whitespace/indent] [3]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|34| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|36| private: should be indented +1 space inside class JVisionCameraProxy [whitespace/indent] [3]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|37| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|38| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|39| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|40| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|42| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|43| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|44| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|45| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|46| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|47| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|48| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|49| Tab found; better to use spaces [whitespace/tab] [1]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|52| Namespace should be terminated with "// namespace vision" [readability/namespace] [5]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|27| Add #include for string [build/include_what_you_use] [4]
android/src/main/cpp/java-bindings/JVisionCameraProxy.h|44| Add #include for shared_ptr<> [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:34:50Z

android/src/main/cpp/VisionCameraProxy.cpp

+	_javaProxy->cthis()->removeFrameProcessor(viewTag);
+}
+
+jsi::Value VisionCameraProxy::getFrameProcessorPlugin(jsi::Runtime& runtime, std::string name, const jsi::Object& jsOptions) {


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:34:50Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+																																	 runtime,
+																																	 runOnJS,
+																																	 runOnWorklet);
+	__android_log_write(ANDROID_LOG_INFO, TAG, "Worklet Context created!");


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:34:50Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+
+
+void JVisionCameraProxy::setFrameProcessor(int viewTag,
+																					 alias_ref<JFrameProcessor::javaobject> frameProcessor) {


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:34:50Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+
+void JVisionCameraProxy::setFrameProcessor(int viewTag,
+																					 alias_ref<JFrameProcessor::javaobject> frameProcessor) {
+	auto setFrameProcessorMethod = javaClassLocal()->getMethod<void(int, alias_ref<JFrameProcessor::javaobject>)>("setFrameProcessor");


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:34:50Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+void JVisionCameraProxy::setFrameProcessor(int viewTag,
+																					 alias_ref<JFrameProcessor::javaobject> frameProcessor) {
+	auto setFrameProcessorMethod = javaClassLocal()->getMethod<void(int, alias_ref<JFrameProcessor::javaobject>)>("setFrameProcessor");
+	setFrameProcessorMethod(_javaPart, viewTag, frameProcessor);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:34:53Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+	removeFrameProcessorMethod(_javaPart, viewTag);
+}
+
+local_ref<JFrameProcessorPlugin::javaobject> JVisionCameraProxy::getFrameProcessorPlugin(std::string name,


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:34:53Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+	return makeCxxInstance(jThis, jsRuntime, jsCallInvoker, sharedScheduler);
+}
+
+}


[cpplint] _{reported by reviewdog 🐶}
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2023-07-21T21:34:53Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+using namespace facebook;
+
+class JVisionCameraProxy : public jni::HybridClass<JVisionCameraProxy> {
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class JVisionCameraProxy [whitespace/indent] [3]

github-actions · 2023-07-21T21:34:53Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+
+class JVisionCameraProxy : public jni::HybridClass<JVisionCameraProxy> {
+public:
+	static void registerNatives();


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:34:53Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+public:
+	static void registerNatives();
+
+	void setFrameProcessor(int viewTag,


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:39:08Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	static void registerNatives();
+
+	void setFrameProcessor(int viewTag,
+												 jni::alias_ref<JFrameProcessor::javaobject> frameProcessor);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:39:09Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+
+	void setFrameProcessor(int viewTag,
+												 jni::alias_ref<JFrameProcessor::javaobject> frameProcessor);
+	void removeFrameProcessor(int viewTag);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:39:09Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	void setFrameProcessor(int viewTag,
+												 jni::alias_ref<JFrameProcessor::javaobject> frameProcessor);
+	void removeFrameProcessor(int viewTag);
+	jni::local_ref<JFrameProcessorPlugin::javaobject> getFrameProcessorPlugin(std::string name,


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:39:09Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+												 jni::alias_ref<JFrameProcessor::javaobject> frameProcessor);
+	void removeFrameProcessor(int viewTag);
+	jni::local_ref<JFrameProcessorPlugin::javaobject> getFrameProcessorPlugin(std::string name,
+																																						jni::local_ref<react::ReadableNativeMap::javaobject> options);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:39:09Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	jni::local_ref<JFrameProcessorPlugin::javaobject> getFrameProcessorPlugin(std::string name,
+																																						jni::local_ref<react::ReadableNativeMap::javaobject> options);
+
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class JVisionCameraProxy [whitespace/indent] [3]

github-actions · 2023-07-21T21:39:11Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+															jni::global_ref<JVisionCameraScheduler::javaobject> scheduler);
+	static jni::local_ref<jhybriddata> initHybrid(jni::alias_ref<jhybridobject> javaThis,
+																								jlong jsRuntimePointer,
+																								jni::alias_ref<facebook::react::CallInvokerHolder::javaobject> jsCallInvokerHolder,


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:39:11Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	static jni::local_ref<jhybriddata> initHybrid(jni::alias_ref<jhybridobject> javaThis,
+																								jlong jsRuntimePointer,
+																								jni::alias_ref<facebook::react::CallInvokerHolder::javaobject> jsCallInvokerHolder,
+																								jni::alias_ref<JVisionCameraScheduler::javaobject> scheduler);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:39:11Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+																								jni::alias_ref<JVisionCameraScheduler::javaobject> scheduler);
+};
+
+}


[cpplint] _{reported by reviewdog 🐶}
Namespace should be terminated with "// namespace vision" [readability/namespace] [5]

github-actions · 2023-07-21T21:39:11Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	void setFrameProcessor(int viewTag,
+												 jni::alias_ref<JFrameProcessor::javaobject> frameProcessor);
+	void removeFrameProcessor(int viewTag);
+	jni::local_ref<JFrameProcessorPlugin::javaobject> getFrameProcessorPlugin(std::string name,


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:39:11Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+
+	explicit JVisionCameraProxy(jni::alias_ref<JVisionCameraProxy::jhybridobject> javaThis,
+															jsi::Runtime* jsRuntime,
+															std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker,


[cpplint] _{reported by reviewdog 🐶}
Add #include for shared_ptr<> [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:39:57Z

example/src/CameraPage.tsx

@@ -8,6 +8,7 @@ import {
  PhotoFile,
  sortFormats,
  useCameraDevices,
+  useFrameProcessor,
  useSkiaFrameProcessor,


[tsc] <6133> _{reported by reviewdog 🐶}
'useSkiaFrameProcessor' is declared but its value is never read.

github-actions · 2023-07-21T21:39:58Z

example/src/CameraPage.tsx

@@ -218,15 +219,10 @@
  paint.setImageFilter(imageFilter);

  const isIOS = Platform.OS === 'ios';


[tsc] <6133> _{reported by reviewdog 🐶}
'isIOS' is declared but its value is never read.

github-actions · 2023-07-21T21:47:28Z

android/src/main/cpp/VisionCameraProxy.cpp

+}
+
+jsi::Value VisionCameraProxy::getFrameProcessorPlugin(jsi::Runtime& runtime,
+                                                      const std::string& name,


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:47:28Z

android/src/main/cpp/VisionCameraProxy.h

+private:
+  void setFrameProcessor(int viewTag, jsi::Runtime& runtime, const jsi::Object& frameProcessor);
+  void removeFrameProcessor(int viewTag);
+  jsi::Value getFrameProcessorPlugin(jsi::Runtime& runtime, const std::string& name, const jsi::Object& options);


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:47:28Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+
+JVisionCameraProxy::JVisionCameraProxy(const jni::alias_ref<JVisionCameraProxy::jhybridobject>& javaThis,
+																			 jsi::Runtime* runtime,
+																			 const std::shared_ptr<facebook::react::CallInvoker>& callInvoker,


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:47:28Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+JVisionCameraProxy::JVisionCameraProxy(const jni::alias_ref<JVisionCameraProxy::jhybridobject>& javaThis,
+																			 jsi::Runtime* runtime,
+																			 const std::shared_ptr<facebook::react::CallInvoker>& callInvoker,
+																			 const jni::global_ref<JVisionCameraScheduler::javaobject>& scheduler) {


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:47:28Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.cpp

+
+
+void JVisionCameraProxy::setFrameProcessor(int viewTag,
+																					 const alias_ref<JFrameProcessor::javaobject>& frameProcessor) {


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:47:30Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+
+	explicit JVisionCameraProxy(const jni::alias_ref<JVisionCameraProxy::jhybridobject>& javaThis,
+															jsi::Runtime* jsRuntime,
+															const std::shared_ptr<facebook::react::CallInvoker>& jsCallInvoker,


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:47:30Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	explicit JVisionCameraProxy(const jni::alias_ref<JVisionCameraProxy::jhybridobject>& javaThis,
+															jsi::Runtime* jsRuntime,
+															const std::shared_ptr<facebook::react::CallInvoker>& jsCallInvoker,
+															const jni::global_ref<JVisionCameraScheduler::javaobject>& scheduler);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:47:30Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	static jni::local_ref<jhybriddata> initHybrid(jni::alias_ref<jhybridobject> javaThis,
+																								jlong jsRuntimePointer,
+																								jni::alias_ref<facebook::react::CallInvokerHolder::javaobject> jsCallInvokerHolder,
+																								const jni::alias_ref<JVisionCameraScheduler::javaobject>& scheduler);


[cpplint] _{reported by reviewdog 🐶}
Tab found; better to use spaces [whitespace/tab] [1]

github-actions · 2023-07-21T21:47:30Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+	void setFrameProcessor(int viewTag,
+												 const jni::alias_ref<JFrameProcessor::javaobject>& frameProcessor);
+	void removeFrameProcessor(int viewTag);
+	jni::local_ref<JFrameProcessorPlugin::javaobject> getFrameProcessorPlugin(const std::string& name,


[cpplint] _{reported by reviewdog 🐶}
Add #include for string [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:47:30Z

android/src/main/cpp/java-bindings/JVisionCameraProxy.h

+
+	explicit JVisionCameraProxy(const jni::alias_ref<JVisionCameraProxy::jhybridobject>& javaThis,
+															jsi::Runtime* jsRuntime,
+															const std::shared_ptr<facebook::react::CallInvoker>& jsCallInvoker,


[cpplint] _{reported by reviewdog 🐶}
Add #include for shared_ptr<> [build/include_what_you_use] [4]

github-actions · 2023-07-21T21:53:45Z

android/src/main/cpp/java-bindings/JFrameProcessorPlugin.h

@@ -18,16 +19,12 @@ using namespace jni;
 struct JFrameProcessorPlugin : public JavaClass<JFrameProcessorPlugin> {
  static constexpr auto kJavaDescriptor = "Lcom/mrousavy/camera/frameprocessor/FrameProcessorPlugin;";

- public:
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside struct JFrameProcessorPlugin [whitespace/indent] [3]

github-actions · 2023-07-21T21:55:05Z

android/src/main/cpp/FrameHostObject.h

- public:
-  explicit FrameHostObject(jni::alias_ref<JImageProxy::javaobject> image);
+  explicit FrameHostObject(const jni::alias_ref<JFrame::javaobject>& frame);
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class FrameHostObject [whitespace/indent] [3]

github-actions · 2023-07-21T21:55:06Z

android/src/main/cpp/FrameHostObject.h

  ~FrameHostObject();

- public:
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class FrameHostObject [whitespace/indent] [3]

github-actions · 2023-07-21T21:55:06Z

android/src/main/cpp/FrameHostObject.h

  jsi::Value get(jsi::Runtime &, const jsi::PropNameID &name) override;
  std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime &rt) override;

- public:
-  jni::global_ref<JImageProxy> frame;
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class FrameHostObject [whitespace/indent] [3]

github-actions · 2023-07-21T21:55:06Z

android/src/main/cpp/FrameHostObject.h


- private:
+private:


[cpplint] _{reported by reviewdog 🐶}
private: should be indented +1 space inside class FrameHostObject [whitespace/indent] [3]

github-actions · 2023-07-21T21:55:06Z

android/src/main/cpp/java-bindings/JVisionCameraScheduler.h

-class VisionCameraScheduler : public jni::HybridClass<VisionCameraScheduler> {
- public:
+class JVisionCameraScheduler : public jni::HybridClass<JVisionCameraScheduler> {
+public:


[cpplint] _{reported by reviewdog 🐶}
public: should be indented +1 space inside class JVisionCameraScheduler [whitespace/indent] [3]

github-actions · 2023-07-21T21:55:06Z

android/src/main/cpp/java-bindings/JVisionCameraScheduler.h


- private:
+private:


[cpplint] _{reported by reviewdog 🐶}
private: should be indented +1 space inside class JVisionCameraScheduler [whitespace/indent] [3]

* First Android rewrite * Rewrite Android C++ backend * Pass `ReadableNativeMap`, fix build error * fix: Fix FrameProcessor init * Make a bunch of stuff const reference to avoid copies * Indents * Cleanup * indents * docs: Update Android docs * Update CameraView.kt * fix: Format C++ code

First Android rewrite

0611b73

vercel bot deployed to Preview July 21, 2023 15:54 View deployment

github-actions bot reviewed Jul 21, 2023

View reviewed changes

Rewrite Android C++ backend

4a82509

vercel bot deployed to Preview July 21, 2023 21:08 View deployment

github-actions bot reviewed Jul 21, 2023

View reviewed changes

Pass ReadableNativeMap, fix build error

def0921

vercel bot deployed to Preview July 21, 2023 21:34 View deployment

github-actions bot reviewed Jul 21, 2023

View reviewed changes

fix: Fix FrameProcessor init

8efb1cc

vercel bot deployed to Preview July 21, 2023 21:39 View deployment

github-actions bot reviewed Jul 21, 2023

View reviewed changes

Make a bunch of stuff const reference to avoid copies

ce0cc91

vercel bot deployed to Preview July 21, 2023 21:47 View deployment

github-actions bot reviewed Jul 21, 2023

View reviewed changes

Indents

c288545

vercel bot deployed to Preview July 21, 2023 21:53 View deployment

Cleanup

456571f

github-actions bot reviewed Jul 21, 2023

View reviewed changes

vercel bot deployed to Preview July 21, 2023 21:53 View deployment

indents

8b11200

vercel bot deployed to Preview July 21, 2023 21:54 View deployment

github-actions bot reviewed Jul 21, 2023

View reviewed changes

mrousavy added 2 commits July 22, 2023 00:00

docs: Update Android docs

cdfb713

Update CameraView.kt

ca4bf22

vercel bot deployed to Preview July 21, 2023 22:01 View deployment

fix: Format C++ code

f8aec55

vercel bot deployed to Preview July 21, 2023 22:12 View deployment

mrousavy marked this pull request as ready for review July 21, 2023 22:13

mrousavy merged commit 86dd703 into v3 Jul 21, 2023
10 of 12 checks passed

mrousavy deleted the feat/proxy-object-android branch July 21, 2023 22:15



		void VisionCameraInstaller::install(jni::alias_ref<jni::JClass>,
		jni::alias_ref<JVisionCameraProxy::javaobject> proxy) {



		void JVisionCameraProxy::setFrameProcessor(int viewTag,
		alias_ref<JFrameProcessor::javaobject> frameProcessor) {

		@@ -218,15 +219,10 @@
		paint.setImageFilter(imageFilter);

		const isIOS = Platform.OS === 'ios';



		void JVisionCameraProxy::setFrameProcessor(int viewTag,
		const alias_ref<JFrameProcessor::javaobject>& frameProcessor) {

feat: Rewrite Android C++ part (VisionCameraProxy + JFrame) #1661

feat: Rewrite Android C++ part (VisionCameraProxy + JFrame) #1661

Conversation

mrousavy commented Jul 21, 2023 • edited Loading

What

Changes

Tested on

Related issues

vercel bot commented Jul 21, 2023 • edited Loading

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

Choose a reason for hiding this comment

github-actions bot Jul 21, 2023

feat: Rewrite Android C++ part (`VisionCameraProxy` + `JFrame`) #1661

feat: Rewrite Android C++ part (`VisionCameraProxy` + `JFrame`) #1661

mrousavy commented Jul 21, 2023 •

edited

Loading

vercel bot commented Jul 21, 2023 •

edited

Loading