fix: fix ios reload by observing RCT module invalidate #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey thanks for your Pr this is really interesting! |
pascaldevink
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves IOS crash on reload
Changes
Store reference to viewTag
Clear
CameraView.frameProcessorCallbackonRCTBridgeDidInvalidateModulesNotificationTested on
iPad Pro 2017
Related issues
Fixes #1360
Inspired by
software-mansion/react-native-reanimated#3932
Note that this fix isn't perfect:
However despite this it should improve things considerably (Until v3), I was able to get around 15 reloads with no memory issues.