fix: Fix not-found plugins crashing the app (#3076)

* fix: Fix not-found plugins crashing the app * fix: Fix Example Plugin wrong name * Update VisionCameraProxy.cpp
mrousavy · Jul 12, 2024 · 38199e2 · 38199e2
1 parent 4754065
commit 38199e2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/package/android/src/main/cpp/frameprocessors/VisionCameraProxy.cpp b/package/android/src/main/cpp/frameprocessors/VisionCameraProxy.cpp
@@ -53,6 +53,9 @@ jsi::Value VisionCameraProxy::initFrameProcessorPlugin(jsi::Runtime& runtime, co
   auto options = JSIJNIConversion::convertJSIObjectToJNIMap(runtime, jsOptions);
 
   auto plugin = _javaProxy->cthis()->initFrameProcessorPlugin(name, options);
+  if (plugin == nullptr) {
+    return jsi::Value::undefined();
+  }
 
   auto pluginHostObject = std::make_shared<FrameProcessorPluginHostObject>(plugin);
   return jsi::Object::createFromHostObject(runtime, pluginHostObject);

diff --git a/package/example/android/app/src/main/java/com/mrousavy/camera/example/MainApplication.kt b/package/example/android/app/src/main/java/com/mrousavy/camera/example/MainApplication.kt
@@ -17,7 +17,7 @@ import com.mrousavy.camera.frameprocessors.FrameProcessorPluginRegistry
 class MainApplication : Application(), ReactApplication {
   companion object {
     init {
-        FrameProcessorPluginRegistry.addFrameProcessorPlugin("example") { proxy, args -> ExampleFrameProcessorPlugin(proxy, args) }
+        FrameProcessorPluginRegistry.addFrameProcessorPlugin("example_plugin") { proxy, args -> ExampleFrameProcessorPlugin(proxy, args) }
         FrameProcessorPluginRegistry.addFrameProcessorPlugin("example_kotlin_swift_plugin") { proxy, args -> ExampleKotlinFrameProcessorPlugin(proxy, args) }
     }
   }