Merge pull request #8 from tgermain/input_check

Gopkg.toml

@@ -34,9 +34,10 @@
   unused-packages = true
 
 [[constraint]]
-  branch = "dev/tg/getenvvar"
+  branch = "dev/tg/regex"
   name = "github.com/jszwedko/go-circleci"
   source = "github.com/tgermain/go-circleci"
 # waiting for https://github.com/jszwedko/go-circleci/pull/14 to be merged to be able to use 1.1 API
 # waiting for https://github.com/tylux/go-circleci/pull/1 to be merged to fix the tests
 # waiting for https://github.com/tylux/go-circleci/pull/2 to be merged to add GetEnvVar
+# waiting for https://github.com/tylux/go-circleci/pull/3 to be merged for have access to EnvVarNameValidRE

circleci/resource_circleci_environment_variable.go

@@ -7,6 +7,8 @@ import (
 	"time"
 
 	"github.com/hashicorp/terraform/helper/schema"
+
+	circleciapi "github.com/jszwedko/go-circleci"
 )
 
 func resourceCircleCIEnvironmentVariable() *schema.Resource {
@@ -36,6 +38,17 @@ func resourceCircleCIEnvironmentVariable() *schema.Resource {
 				Type:        schema.TypeString,
 				Required:    true,
 				ForceNew:    true,
+				ValidateFunc: func(i interface{}, keyName string) (warnings []string, errors []error) {
+					v, ok := i.(string)
+					if !ok {
+						return nil, []error{fmt.Errorf("expected type of %s to be string", keyName)}
+					}
+					if !circleciapi.ValidateEnvVarName(v) {
+						return nil, []error{fmt.Errorf("environment variable name %s is not valid. See https://circleci.com/docs/2.0/env-vars/#injecting-environment-variables-with-the-api", v)}
+					}
+
+					return nil, nil
+				},
 			},
 			"value": &schema.Schema{
 				Description: "The value of the environment variable",