Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal typing support and fix py3.10 #114

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JacobHayes
Copy link

@JacobHayes JacobHayes commented Apr 18, 2021

Changes from inspect.Parameter.annotation to typing.get_type_hints in order to accommodate string annotations from:

  • explicit string hints
  • PEP 563: default in py >=3.10, from __future__ import annotations in py <3.9

Also adds some minimal type hints to Dispatcher to ease mypy typing in downstream use - happy to separate this part.

Resolves #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks under __future__.annotations
1 participant