Skip to content

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Greymagic27 committed Dec 24, 2024
1 parent efa58f7 commit 600bc99
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ extensive statistics system, handles YAML configuration files and features fancy

## :star: Support and feedback

Thought of a cool idea? Found a problem or need some help? Simply open an [**issue
**](https://github.com/mrfdev/advanced-achievements/issues)!
Thought of a cool idea? Found a problem or need some help? Simply open an [**issue**](https://github.com/mrfdev/advanced-achievements/issues)!

Find the project useful, fun or interesting? **Star** the repository by clicking on the icon on the top right of this
page!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ void shouldParseMaxHealthReward() throws Exception {
assertEquals(Arrays.asList("increase max health by 2"), reward.getListTexts());
assertEquals(Arrays.asList("Your max health has increased by 2!"), reward.getChatTexts());
reward.getRewarder().accept(player);
verify(player).getAttribute(Attribute.GENERIC_MAX_HEALTH);
verify(player).getAttribute(Attribute.MAX_HEALTH);
verify(healthAttribute).setBaseValue(3.0);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import org.bukkit.Material;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.PotionMeta;
import org.bukkit.potion.PotionData;
import org.bukkit.potion.PotionType;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
Expand All @@ -25,7 +24,7 @@ class MaterialHelperTest {

@Test
void shouldReturnFalseForWaterPotion() {
when(potionMeta.getBasePotionData()).thenReturn(new PotionData(PotionType.WATER));
when(potionMeta.getBasePotionType()).thenReturn(PotionType.WATER);
when(itemStack.getItemMeta()).thenReturn(potionMeta);
when(itemStack.getType()).thenReturn(Material.POTION);
MaterialHelper underTest = new MaterialHelper(null);
Expand All @@ -35,7 +34,7 @@ void shouldReturnFalseForWaterPotion() {

@Test
void shouldReturnTrueForOtherPotion() {
when(potionMeta.getBasePotionData()).thenReturn(new PotionData(PotionType.INSTANT_DAMAGE));
when(potionMeta.getBasePotionType()).thenReturn(PotionType.HARMING);
when(itemStack.getItemMeta()).thenReturn(potionMeta);
when(itemStack.getType()).thenReturn(Material.POTION);
MaterialHelper underTest = new MaterialHelper(null);
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>21</java.version>
<revision>7.1.5</revision>
<revision>7.1.6</revision>
<maven.test.skip>true</maven.test.skip>
</properties>

Expand Down

0 comments on commit 600bc99

Please sign in to comment.