Code review fixes

mrdoob · Jan 22, 2020 · 5ec904d · 5ec904d
1 parent f20e8da
commit 5ec904d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/examples/js/loaders/GLTFLoader.js b/examples/js/loaders/GLTFLoader.js
@@ -223,8 +223,6 @@ THREE.GLTFLoader = ( function () {
 
 			if ( this.lazy ) {
 
-				parser.markDefs();
-
 				onLoad( { parser: parser } );
 
 			} else {
@@ -1463,6 +1461,9 @@ THREE.GLTFLoader = ( function () {
 
 		}
 
+		// Mark the special nodes/meshes in json for efficient parse
+		this.markDefs();
+
 	}
 
 	GLTFParser.prototype.parse = function ( onLoad, onError ) {
@@ -1474,9 +1475,6 @@ THREE.GLTFLoader = ( function () {
 		// Clear the loader cache
 		this.cache.removeAll();
 
-		// Mark the special nodes/meshes in json for efficient parse
-		this.markDefs();
-
 		Promise.all( [
 
 			this.getDependencies( 'scene' ),

diff --git a/examples/jsm/loaders/GLTFLoader.d.ts b/examples/jsm/loaders/GLTFLoader.d.ts
@@ -37,6 +37,7 @@ export class GLTFLoader extends Loader {
 	setDDSLoader( ddsLoader: DDSLoader ): GLTFLoader;
 	parse( data: ArrayBuffer | string, path: string, onLoad: ( gltf: GLTF ) => void, onError?: ( event: ErrorEvent ) => void ) : void;
 	setLazyLoad( lazy: boolean ) : void;
+
 }
 
 export class GLTFParser {

diff --git a/examples/jsm/loaders/GLTFLoader.js b/examples/jsm/loaders/GLTFLoader.js
@@ -291,8 +291,6 @@ var GLTFLoader = ( function () {
 
 			if ( this.lazy ) {
 
-				parser.markDefs();
-
 				onLoad( { parser: parser } );
 
 			} else {
@@ -1531,6 +1529,9 @@ var GLTFLoader = ( function () {
 
 		}
 
+		// Mark the special nodes/meshes in json for efficient parse
+		this.markDefs();
+
 	}
 
 	GLTFParser.prototype.parse = function ( onLoad, onError ) {
@@ -1542,9 +1543,6 @@ var GLTFLoader = ( function () {
 		// Clear the loader cache
 		this.cache.removeAll();
 
-		// Mark the special nodes/meshes in json for efficient parse
-		this.markDefs();
-
 		Promise.all( [
 
 			this.getDependencies( 'scene' ),