Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dap): don't load lldb_commands when using codelldb #140

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mrcjkb
Copy link
Owner

@mrcjkb mrcjkb commented Jan 8, 2024

Fixes #139.

@SlayerOfTheBad if I understand your description correctly, this should fix it?
I haven't had time to test it yet...

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@SlayerOfTheBad
Copy link

Yeah that works. I just tested it locally and encountered no issues.

@mrcjkb mrcjkb merged commit eaa3296 into master Jan 8, 2024
@mrcjkb mrcjkb deleted the codelldb-fix branch January 8, 2024 15:54
@mrcjkb
Copy link
Owner Author

mrcjkb commented Jan 8, 2024

Yeah that works. I just tested it locally and encountered no issues.

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't load lldb_commands when using codelldb
2 participants