-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract a struct for building bitmaps #405
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR doesn't go far enough. Bitmap handling is probably one of the most easily abstracted out parts of the code.
My expectation is that the only interface that needs to be exposed to the main part of the model is:
// some enums...
class BitmapBuilder
{
public:
BitmapBuilder(/* Init stuff */);
void record_activity(type, position);
void output(filename, format) const;
};
See #399 for some recent changes which I think we could take further as population/infected/recovered/treated could be converted into enums themselves.
@matt-gretton-dann Just a first pass as I'm wary about trying to get changes accepted given that I've had several PRs just rotting for over a month leaving really bad merge conflicts to get resolved. |
93b5ee8
to
1cb50d6
Compare
8e92aea
to
3b1eb68
Compare
b3c42d5
to
0827afb
Compare
First pass tidy up as seen in the video referenced in #403