Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add std test-and-release workflow #640

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

mcm1957
Copy link
Contributor

@mcm1957 mcm1957 commented Feb 20, 2024

This PR adds the ioBroker standard test-and-release workflow.

Please merge into you setup.
Maybe this std workflow duplicates tests of nodejs.yml. So eventually you want to check / adapt / remove those workflows.

Although using the standard workflow is NOT mandatory the tests contained in it (or equivalent tests) are mandatory for an adapter to be listed at the repositories. Usinf the standard workflow redudes work needed to check as at least partly an automatic check can be performed.

Thnaks for your cooperation adn eventually merging the PR.

And THANKS A LOT that you spend time for an ioBroker adapter and provide it to others,

@mrbungle64
Copy link
Owner

@mcm1957

This PR adds the ioBroker standard test-and-release workflow.

Please merge into you setup. Maybe this std workflow duplicates tests of nodejs.yml. So eventually you want to check / adapt / remove those workflows.

Thanks for your PR 👍🏻

@mrbungle64
Copy link
Owner

Maybe I should bump the minimum required version of Node.js to 18.x
Engine breaks builds #482

@mcm1957
Copy link
Contributor Author

mcm1957 commented Feb 20, 2024

No problem. It's completly OK to require node 18 in the meantime.
Node 16 is no longer supported since months and ioBroker simply does not yet block it activly. Bute inode 16 is no longer required to be supported and ioBroker recommends node 18 since some time ago. Several adapters require node 18 minimum in the meantime.

You should:

  • adapt engines at package,json
  • remove node 16 from test-and-release workflow
  • increase at least the minor version number if you require node 18 or newer now.

@mrbungle64 mrbungle64 merged commit fff9e52 into mrbungle64:master Feb 20, 2024
8 of 16 checks passed
@mrbungle64
Copy link
Owner

@mcm1957
Thanks 👍🏻

You should:

  • adapt engines at package,json
  • remove node 16 from test-and-release workflow
  • increase at least the minor version number if you require node 18 or newer now.

Done 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants