CI: Github MacOS now uses ARM64. #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of Nim x86 in compat mode that fails with inline ASM.
|
This is pending Nim MacOS ARM nightly releases: nim-lang/nightlies#82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #372
Github runners now use ARM64 instead of x86 for MacOS.
Constantine failed to compile for inline assembly when the target CPU architecture is not explicit.
This suggests that the wrong architecture (x86) was used for compiling on ARM64.
Looking at
nim -v, Nim x86 was installed and used, probably transparently through Rosetta. And the x86 check atconstantine/constantine/platforms/config.nim
Lines 12 to 13 in 976c8bb
use the "native" compiler config.
Hence this only affects the CI, and this should be fixable with just a change to arm64.