Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move staticFor to the inner repo #216

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Move staticFor to the inner repo #216

merged 1 commit into from
Feb 7, 2023

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Feb 7, 2023

Nimble unfortunately removes all folders including tests and benchmarks (and bindings?) on installation. Which is absolutely wrong, especially for libraries tuned to the hardware (bigEndian?).

In our case, the libraries doesn't work at all because staticFor is in the helpers/ directory. Move it out.

cc @treeform, cc @guzba

Even nimble needed to use a hack around their recommended src structure

https://github.com/nim-lang/nimble/blob/b629048249ae63117ff90a813037dccab2965983/nimble.nimble#L4-L9

@mratsim mratsim merged commit 7c5421f into master Feb 7, 2023
@mratsim mratsim deleted the static-for branch February 7, 2023 12:52
@treeform
Copy link

treeform commented Feb 7, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants