Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly allow openArray in Tensor [], []=, fix the CI #666

Merged
merged 6 commits into from
Sep 20, 2024

Commits on Sep 20, 2024

  1. explicitly allow openArray in [], []= for tensors

    This was simply an oversight obviously
    Vindaar committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3e7dce6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    836c6b2 View commit details
    Browse the repository at this point in the history
  3. need a space, duh

    Vindaar committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7a93d38 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5a28ccf View commit details
    Browse the repository at this point in the history
  5. fix regression caused by PR #659

    By not resetting the offset here, operating on a Tensor view without
    cloning could cause undefined behavior, because we would be accessing
    elements outside the tensor buffer.
    Vindaar committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    93a6506 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    46c1206 View commit details
    Browse the repository at this point in the history