A deleter field (function pointer) for CpuStorageObj #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added a
deleter
field toCpuStorageObj
, which will be called onmemalloc
field instead ofdeallocShared
if notnil
.Why
This change allows the implementation of memory sharing with other objects. For example, we can acquire memory from some opaque type
or we can wrap the tensor's memory into a shared pointer, and make
deleter
to delete a single copy of this pointer. This will facilitate sharing memory owned by tensors between threads.How
A field
deleter: proc(memalloc: pointer) {.noconv, gcsafe, raises: [].}
was added to theCpuStorageObj
. This field is then used in the destructor.