add prompting to deploy even when the board configuration is unexpected #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraleson
requested changes
May 6, 2022
There was a problem hiding this comment.
Thanks Tammy, looks great. I left 2 suggestions, removing the unused imports and I think we should only allow the override if someone specified the device (the device wasn't auto-detected). I don't think it should be possible to auto-detect an incorrect device but just in case we missed something.
|
|
||
| import shutil | ||
| import platform | ||
| import os # pylint:disable=unused-import |
There was a problem hiding this comment.
If imports are unused, please remove instead of ignoring.
| return | ||
| if not has_correct_size(device): | ||
| print('Specified CircuitPython drive is larger than expected (~{:0d}MB).'.format(int(DEFAULT_BOARD_CAPACITY // 1E6))) | ||
| if not warning_prompt(f'Are you sure you want to deploy to {device}?'): |
There was a problem hiding this comment.
Suggested change
| if not warning_prompt(f'Are you sure you want to deploy to {device}?'): | |
| if not args.device or not warning_prompt(f'Are you sure you want to deploy to {device}?'): |
Only allow override only if the device was specified (not auto detected). Otherwise someone might blast through the warning and erase their hard drive.
| user_confirmed = True | ||
| if not has_correct_label(device, expected_label): | ||
| print(f'Expected device to have {expected_label} in path.') | ||
| if not warning_prompt(f'Are you sure you want to deploy to {device}?'): |
There was a problem hiding this comment.
Suggested change
| if not warning_prompt(f'Are you sure you want to deploy to {device}?'): | |
| if not args.device or not warning_prompt(f'Are you sure you want to deploy to {device}?'): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #14 and implements some checking to make the code (cautiously) deploy even when the target directory doesn't appear to be a valid CircuitPython device. If the directory the user is deploying to does not have the right label, or appears to be larger than what we'd expect a microcontroller device to be, the user will be prompted for confirmation before deploying to that device.