Skip to content

Commit

Permalink
Use localhost for Cypress CI
Browse files Browse the repository at this point in the history
  • Loading branch information
mraible committed Dec 5, 2023
2 parents 025ddb2 + ae4e5b5 commit 3428109
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
- name: Run integration tests
uses: cypress-io/github-action@v6
with:
browser: chrome
start: npm start
install: false
wait-on: http://[::1]:4200
wait-on: http://localhost:4200
6 changes: 2 additions & 4 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ Modify `EditComponent` to import model and service classes and to use the `Searc
[source,typescript]
.src/app/edit/edit.component.ts
----
import { Component, OnInit, OnDestroy } from '@angular/core';
import { Component, OnDestroy, OnInit } from '@angular/core';
import { Person, SearchService } from '../shared';
import { Subscription } from 'rxjs';
import { ActivatedRoute, Router } from '@angular/router';
Expand Down Expand Up @@ -1380,11 +1380,9 @@ jobs:
browser: chrome
start: npm start
install: false
wait-on: http://[::1]:4200
wait-on: http://localhost:4200
----

TIP: See https://github.com/cypress-io/github-action/issues/634[issue #634] for more information on the strange syntax for `wait-on`.

Check it in on a branch, create a pull request for that branch, and you should see your tests running.

=== Jenkins
Expand Down

0 comments on commit 3428109

Please sign in to comment.