Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show duplicates on non-unique query #73

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

Closes #59

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (09d212b) 88.05% compared to head (5bf1f98) 87.36%.
Report is 2 commits behind head on main.

Files Patch % Lines
filefinder/_filefinder.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   88.05%   87.36%   -0.70%     
==========================================
  Files           5        5              
  Lines         268      269       +1     
==========================================
- Hits          236      235       -1     
- Misses         32       34       +2     
Flag Coverage Δ
unittests 87.36% <0.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Can you add a short entry in the CHANGELOG?

filefinder/_filefinder.py Outdated Show resolved Hide resolved
filefinder/_filefinder.py Outdated Show resolved Hide resolved
Remove comment

Co-authored-by: Mathias Hauser <[email protected]>
@mathause
Copy link
Collaborator

mathause commented Feb 7, 2024

Thanks!

@mathause mathause merged commit 6b89335 into mpytools:main Feb 7, 2024
6 checks passed
mathause pushed a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show duplicates on non-unique query
2 participants