win32: fix the issue of menu click failure caused by excessive menu-data updates #15701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
basically a copy of tsl0922/mpv-menu-plugin#77 if you have 200+ menu items and update `menu-data` about 400 times, clicking menu item will not execute any command, the reason is that the menu identifier greater than the max value of 16-bit unsigned integer. 1. make menu id always less than 0xF000 as mpv-player/mpv@861908c7 said 2. old menu items are never reused, should delete by DeleteMenu() instead of RemoveMenu(), destroys the handle and frees the memory
verygoodlee
force-pushed
the
context-menu-fix
branch
from
8b81729 to
32dca39
Compare
|
this is a simple test config portable_config.zip, contains dyn_menu.lua input.conf and a test.lua run
according to my test in shinchiro's build, click Exit didn't execute any command. test passed in github actions build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically a copy of tsl0922/mpv-menu-plugin#77
if you have 200+ menu items and update
menu-dataabout 400 times, clicking menu item will not execute any command, the reason is that the menu identifier greater than the max value of 16-bit unsigned integer.