input key names fixes #15516
Merged
input key names fixes #15516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shift modifier is used with text key names, it is usually silently ignored, except for ASCII key names, which can be confusing. Document it clearly.
Because mpv keycodes are whatever the text the keyboard input produces, caps lock also affects this.
Document the syntax and mention how it can be used as Unicode codepoints. ASCII range has worked since the feature was inplemented in 86a87de and Unicode range has worked since a63e880. It also works with known special keys if you know the internal values of keys because there is no filtering in place, but this should not be encouraged.
Follow the suggestion of keyname documentation. Fixes: b4d9980
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes and clarification related to key names.