Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select.lua: abort edition selection when there's only 1 #15501

Merged
merged 1 commit into from
Dec 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions player/lua/select.lua
Original file line number Diff line number Diff line change
Expand Up @@ -224,22 +224,23 @@ mp.add_key_binding(nil, "select-chapter", function ()
end)

mp.add_key_binding(nil, "select-edition", function ()
local editions = {}
local default_item = mp.get_property_native("current-edition")
local edition_list = mp.get_property_native("edition-list")

if default_item == nil then
if edition_list == nil or #edition_list == 1 then
show_error("No available editions.")
return
end

for i, edition in ipairs(mp.get_property_native("edition-list")) do
local editions = {}

for i, edition in ipairs(edition_list) do
editions[i] = edition.title
end

input.select({
prompt = "Select an edition:",
items = editions,
default_item = default_item + 1,
default_item = mp.get_property_native("current-edition") + 1,
submit = function (edition)
mp.set_property("edition", edition - 1)
end,
Expand Down
Loading