osc.lua: update mouse bindings #15497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
kasper93
reviewed
Dec 12, 2024
- It makes more sense to select a playlist entry from the buttons that navigate the playlist than from the title - Provides different bindings for right and middle click - Mirrors chapter button bindings
Right clicking playlist arrows already opens the playlist selector so bind something else to right clicking the title. Make it show the full path which is useful but not bound anywhere on either the keyboard or the OSC.
Always list in the order left shift+L middle right click.
guidocella
force-pushed
the
osc-bindings
branch
from
a053225 to
14755db
Compare
kasper93
reviewed
Dec 12, 2024
|
|
||
| title_mbtn_left_command = "script-binding stats/display-page-5", | ||
| title_mbtn_mid_command = "show-text ${filename}", | ||
| title_mbtn_right_command = "script-binding select/select-playlist; script-message-to osc osc-hide", | ||
| title_mbtn_right_command = "show-text ${path}", |
There was a problem hiding this comment.
Should this be $path or $stream-path or $stream-open-file?
There was a problem hiding this comment.
Never heard of stream-path, docs say it's useless. stream-open-filename is the huge EDL string when playing ytdl_hook URLs I don't know why you would want to see that instead of the normal youtube URL.
kasper93
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osc.lua: open the playlist selector when right clicking playlist arrows
osc.lua: show the full path when right clicking the title
Right clicking playlist arrows already opens the playlist selector so bind something else to right clicking the title. Make it show the full path which is useful but not bound anywhere on either the keyboard or the OSC.
DOCS/man/osc: sort mouse bindings consistently
Always list in the order left shift+L middle right click.