TaskRequest Object should only be created if incoming task is persisted

mozzy11 · Oct 20, 2023 · c10ce74 · c10ce74
1 parent 6201727
commit c10ce74
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/api/src/main/java/org/openmrs/module/labonfhir/api/scheduler/FetchTaskUpdates.java b/api/src/main/java/org/openmrs/module/labonfhir/api/scheduler/FetchTaskUpdates.java
@@ -126,11 +126,12 @@ public void execute() {
 				taskBundle = client.loadPage().next(taskBundle).execute();
 				taskBundles.add(taskBundle);
 			}
-			updateTasksInBundle(taskBundles);
-
-			TaskRequest request = new TaskRequest();
-			request.setRequestDate(newDate);
-			labOnFhirService.saveOrUpdateTaskRequest(request);
+			Boolean tasksUpdated = updateTasksInBundle(taskBundles);
+			if (tasksUpdated) {
+				TaskRequest request = new TaskRequest();
+				request.setRequestDate(newDate);
+				labOnFhirService.saveOrUpdateTaskRequest(request);
+			}
 		}
 		catch (Exception e) {
 			log.error("ERROR executing FetchTaskUpdates : " + e.toString() + getStackTrace(e));
@@ -146,7 +147,8 @@ public void shutdown() {
 		this.stopExecuting();
 	}
 
-	private void updateTasksInBundle(List<Bundle> taskBundles) {
+	private Boolean updateTasksInBundle(List<Bundle> taskBundles) {
+		Boolean tasksUpdated = false;
 		for (Bundle bundle : taskBundles) {
 			for (Iterator tasks = bundle.getEntry().iterator(); tasks.hasNext();) {
 				String openmrsTaskUuid = null;
@@ -170,6 +172,7 @@ private void updateTasksInBundle(List<Bundle> taskBundles) {
 						}
 						if (taskOutPutUpdated) {
 							taskService.update(openmrsTaskUuid, openmrsTask);
+							tasksUpdated = taskOutPutUpdated;
 						}
 					}
 				}
@@ -178,6 +181,7 @@ private void updateTasksInBundle(List<Bundle> taskBundles) {
 				}
 			}
 		}
+		return tasksUpdated;
 	}
 
 	private Boolean updateOutput(List<Task.TaskOutputComponent> output, Task openmrsTask) {