Skip to content
This repository was archived by the owner on May 11, 2020. It is now read-only.

Translatable country names (Solves #137) #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bidaian
Copy link
Contributor

@bidaian bidaian commented Jan 3, 2016

This pull requests adds the country codes and English names to openwapp.en-US.properties and it adds a l10n lookup in scripts/collections/countries.js (just one line), based on the country code.

For those locales not translating the country names, nothing changes. But I can prepare another pull request with the translations, from the same source (Firefox - release channel).

I don't know how to test the lookup inside countries.js, and since I'm working on my actual primary devices, I cannot uninstall and reinstall from scratch. Could you take a look at it?

@Timmaks
Copy link
Contributor

Timmaks commented Jan 6, 2016

This is not working, The country list is empty if you did not active your sim with the simcode and if you did active the sim the line 'You have a {{country}} phone number. Change it if it is not correct' does not show a countryname at the place of {{country}}

@willyaranda
Copy link
Member

Mmmm… I don't know if I like this. It's a huge piece of strings to be translated. Also, we need to see if they are listed by the code or the translated name. For example, "Spain" in spanish is "España", and "Germany" is "Alemania". We need to see if we want a sort by code or name.

Both options have problems, for example:

+am=    Armenia
+an=    Netherlands Antilles

Conflicts:
	app/locales/openwapp.en-US.properties
@Timmaks
Copy link
Contributor

Timmaks commented Feb 22, 2016

@bidaian did you work on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants