Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI config to include nodejs v20 #3014

Merged
merged 10 commits into from
Jan 15, 2024
Merged

Conversation

rpl
Copy link
Member

@rpl rpl commented Jan 12, 2024

Fixes #2917

@rpl rpl force-pushed the chore/update-nodejs-ci-v20 branch from f14415e to 7a6edb2 Compare January 12, 2024 20:22
@rpl rpl force-pushed the chore/update-nodejs-ci-v20 branch from 859bdca to b9c063a Compare January 12, 2024 20:47
@rpl
Copy link
Member Author

rpl commented Jan 12, 2024

new attempt... 🤞

Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc, thanks

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
tests/functional/fake-amo-server.js Outdated Show resolved Hide resolved
@rpl rpl force-pushed the chore/update-nodejs-ci-v20 branch from d0bf5fa to 7f2ecdf Compare January 15, 2024 16:02
@rpl rpl merged commit 177fd46 into master Jan 15, 2024
4 checks passed
@rpl rpl deleted the chore/update-nodejs-ci-v20 branch January 15, 2024 17:25
@rpl
Copy link
Member Author

rpl commented Jan 15, 2024

Thanks a lot to @yan12125 for reporting #2917 and invaluable help to investigate and fix it ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support develoment environment using Node.js 20
2 participants