Remove uniffi_bindgen::backend module.
#2495
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards splitting bindings into their own crates. If we are happy to accept binding generation panicing on invalid literals we can remove some low-value code.
bendk
reviewed
Apr 28, 2025
There was a problem hiding this comment.
I kind of liked the to_askama_error function. It's not that big of a deal, but I'd rather return an error than panic if possible. OTOH, I do think the backend module feels a bit weird. What if this was moved to something like a util or error_util module? That feels a bit more light-weight.
Stepping out -- I figured that when bindings are split out into their own crates, they would still have a dependency on uniffi_bindgen and uniffi_bindgen would still be a place for shared code between all the bindings. Did you have something else in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards splitting bindings into their own crates. If we are happy to accept binding generation panicing on invalid literals we can remove some low-value code.
A breaking change :( I'll keep it draft until something else forces one :)