improve language of templates #2444
Conversation
| // This file was autogenerated by some hot garbage in the `uniffi` crate. | ||
| // Trust me, you don't want to mess with it! | ||
| // This file was autogenerated by the `uniffi` crate. | ||
| // DO NOT manually edit this file. |
There was a problem hiding this comment.
You use "DO NOT manually edit this file." here but in other templates you keep "Trust me, you don't want to mess with it!"
Personally I think the original "Trust me, you don't want to mess with it!" is fine
There was a problem hiding this comment.
Thanks, Joe-- not sure why my IDE didn't pick up these changes. Pushed the changes.
Trust me, you don't want to mess with it!
While I agree with personally this language didn't bother me, it did get flagged in an internal audit on our end, which is my motivation for the change.
Open to other language suggestions here, but thought I'd open this PR in case others had similar thoughts / experiences.
Thank you for the consideration.
There was a problem hiding this comment.
it did get flagged in an internal audit on our end
Don't have strong opinion either way, but I'm curious... is this an automated tool that picked up these comments or a manual audit?
There was a problem hiding this comment.
Not sure, but I believe it was a manual audit-- not sure if a (or what) tool was used.
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
suggestion/improve-template-wording
branch
from
3c92f6d to
ac797ad
Compare
Kind request to update the language in the templates. Thank you 🙏