Skip to content
This repository was archived by the owner on Dec 21, 2018. It is now read-only.

Tweak cache settings for better memory usage #289

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Tweak cache settings for better memory usage #289

merged 1 commit into from
Dec 1, 2016

Conversation

willkg
Copy link
Member

@willkg willkg commented Dec 1, 2016

We're running out of memory in prod constantly. My current theory is
that our cache settings are such that we're using an increasing amount
of cache until we pass the threshold for memory allowance.

Assuming that's correct, limiting the caching by number of entries and
timeout should make that better.

This implements that.

We're running out of memory in prod constantly. My current theory is
that our cache settings are such that we're using an increasing amount
of cache until we pass the threshold for memory allowance.

Assuming that's correct, limiting the caching by number of entries and
timeout should make that better.

This implements that.
@willkg
Copy link
Member Author

willkg commented Dec 1, 2016

@willkg
Copy link
Member Author

willkg commented Dec 1, 2016

This is intentionally aggressive. I want to see if this affects things. If it does, then we have proved that cache is part/all of the issue and we can figure out what we want to do from there.

@pmac pmac merged commit 1ddeeb9 into mozilla:master Dec 1, 2016
@willkg willkg deleted the cache-tweaks branch December 2, 2016 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants