This repository was archived by the owner on Dec 21, 2018. It is now read-only.
Tweak cache settings for better memory usage #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running out of memory in prod constantly. My current theory is
that our cache settings are such that we're using an increasing amount
of cache until we pass the threshold for memory allowance.
Assuming that's correct, limiting the caching by number of entries and
timeout should make that better.
This implements that.