Positive on the Cookie Store API (subset) #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakulf
approved these changes
Jun 27, 2024
tantek
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Update makes sense given comments by @martinthomson and @ehsan on #94.
Given that this "positive" is only on a subset of the proposal, we should be precise in exactly what that subset is, and in asking for it, by filing an issue on https://github.com/WICG/cookie-store/issues/ asking for the precise subsetting we want (and believe others will support), and then citing that issue in our positive comment on #94 and/or the 'mozPositionDetail' field in this entry.
In addition, please follow-up on WICG/cookie-store#186 and indicate that we are positive with moving ONLY that subset to the WebApps WG, to help make that happen.
bakulf
approved these changes
Sep 9, 2024
|
See #1106 |
zcorpan
requested changes
Nov 6, 2024
zcorpan
reviewed
Nov 14, 2024
zcorpan
approved these changes
Nov 14, 2024
zcorpan
force-pushed
the
cookiestoreapi
branch
from
504813e to
be3a944
Compare
|
Rebased. Still needs r+ from @tantek |
tantek
approved these changes
Dec 11, 2024
zcorpan
force-pushed
the
cookiestoreapi
branch
from
be3a944 to
5f8fc75
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.