Replace config name with feature check in go/caddy conditions #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
gstrauss
force-pushed
the
replace-form.config-conds
branch
from
3bc203b to
b6d4968
Compare
gstrauss
force-pushed
the
replace-form.config-conds
branch
from
b6d4968 to
c0141a1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
janbrasna
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
|
On Oct 13 in #262 (comment) above, I wrote:
You marked the comment as Resolved. A month has passed. I am merging this PR. @janbrasna this is an example of you not being able to reliably make progress on small, well-scoped changes (or to properly flag the PR with data why the PR is blocked). Note: I created this PR specifically to address your feedback in another PR. |
Instead, prefer to check output.protocols in template conditionals.
gstrauss
force-pushed
the
replace-form.config-conds
branch
from
c0141a1 to
96b23b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
form.configin template conditionalsInstead, prefer to check output.protocols in template conditionals.