-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kubelet #197
base: master
Are you sure you want to change the base?
Add support for Kubelet #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atombrella Have you tried this output in a live config, without errors, and with the constraints really working (i. e. verifying via nmap, curl -vvv --tls* or ssllabs et al. that the intended values are really getting picked up correctly)? Just from glancing the output configs I see some bits that wouldn't work, probably leaving the values unconfigured.
(From the PR description I get it's just a starting point, not sure if you're ready to review… If you need to mark it as a WIP for now you can change it to a draft PR…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atombrella Do you need any more detailed help with the outstanding review bits to be addressed?
TODO:
- TLSv1.3 support Add support for Kubelet #197 (comment)
- correct TLSv1.3 version? Add support for Kubelet #197 (comment)
- ciphers as a sequence Add support for Kubelet #197 (comment)
- test ciphers array length Add support for Kubelet #197 (comment)
- protocols need to use golang format Add support for Kubelet #197 (comment)
- json items ordering Add support for Kubelet #197 (comment)
- kubelet config ordering Add support for Kubelet #197 (comment)
@janbrasna @gene1wood Thank you for the feedback! I'm sorry it took me a while to get back to this. I've posted a couple of screenshots from my local setup. The SSL configurator does indeed start, and you can select either Docker has been helpful to avoid cluttering my local setup; I left a PR to add a Dockerfile to the repository, but haven't received any comments/review. The PR is #178 The configuration file doesn't seem to be very common. Instead, the kube-apiserver.yaml is more common. Thus, I've posted the recommendation that kube-bench
One question that is a bit vague to me, is whether I should leave out the cipher suite parameter for TLS 1.3, instead |
@atombrella I've already written the suggested array check above in #197 (comment) for you incl. the brackets. Same with golang's TLS version formats #197 (comment), if that makes sense you can click-to-commit directly from the suggestion diff. (Netlify is currently not linked to this repo but I'm slowly working on it. The preview is from my QA pull testing…) (The dockerfile PR needs also some love so that's not priority right now; since recently the stack has been updated to hopefully enable higher node versions to plug into automation, so when I have some time I'll check node 20 or LTS compatibility, that's higher priority to work on local machines with newer engines than 12 or 14…) |
I need to work a bit with this, but it's a good first take. Those settings are what the CIS Kubernetes Benchmarks recommend.