Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: oversubscribe cores just a little to make up for slack #2315

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ahartmetz
Copy link
Contributor

...not by factor of 10 as it was done previously

@ahartmetz ahartmetz force-pushed the oversubscribe_cores_less branch from fe6c4f6 to e3f9d04 Compare January 10, 2025 15:10
@ahartmetz ahartmetz force-pushed the oversubscribe_cores_less branch 2 times, most recently from ae01e21 to 8593012 Compare January 10, 2025 19:16
@sylvestre sylvestre requested a review from lissyx January 16, 2025 12:31
@ahartmetz
Copy link
Contributor Author

We agree these CI failures are clearly unrelated to this change, right?

@ahartmetz ahartmetz force-pushed the oversubscribe_cores_less branch from 8593012 to e191d69 Compare January 22, 2025 15:52
...not by a factor of 10 as it was done previously.
@ahartmetz ahartmetz force-pushed the oversubscribe_cores_less branch from e191d69 to 9a7db5a Compare January 22, 2025 16:04
@lissyx lissyx self-requested a review January 24, 2025 06:10
@lissyx lissyx merged commit de991d0 into mozilla:main Jan 24, 2025
57 of 59 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0cc0c62) to head (9a7db5a).
Report is 133 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2315       +/-   ##
==========================================
- Coverage   30.91%       0   -30.92%     
==========================================
  Files          53       0       -53     
  Lines       20112       0    -20112     
  Branches     9755       0     -9755     
==========================================
- Hits         6217       0     -6217     
+ Misses       7922       0     -7922     
+ Partials     5973       0     -5973     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahartmetz ahartmetz deleted the oversubscribe_cores_less branch January 26, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants