Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring "cargo build -Zprofile" support back #2306

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Dec 30, 2024

Close #2297.

In #2282, I mistakenly removed the -Zprofile support, which is still used by many older Rust nightly toolchains. This PR restores this feature.

Additionally, this PR updates the CI to ensure it will not be broken by similar changes in the future.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Dec 30, 2024

cc @sylvestre and @glandium for a review, thanks!

@sylvestre sylvestre requested a review from glandium December 30, 2024 08:44
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Dec 30, 2024

-Zprofile works now:

image

@sylvestre sylvestre merged commit 989e7e3 into main Jan 2, 2025
118 checks passed
@sylvestre sylvestre deleted the bring-z-profile-back branch January 2, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants