-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for caching target json specs for Rust compilation. #2269
base: main
Are you sure you want to change the base?
Add support for caching target json specs for Rust compilation. #2269
Conversation
Could you please add a test here to make sure we don't regress? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
+ Coverage 30.91% 40.65% +9.73%
==========================================
Files 53 54 +1
Lines 20112 20767 +655
Branches 9755 9654 -101
==========================================
+ Hits 6217 8442 +2225
- Misses 7922 8154 +232
+ Partials 5973 4171 -1802 ☔ View full report in Codecov by Sentry. |
Hey @sylvestre, thanks a lot for your quick response! I've checked the integration-tests.yml file you gave me, but it only contains a single test for each platform/compiler, not for individual flags of the Rust compiler. I'm willing to add a test for the newly supported flag, but I need a good example on how sccache currently does per-flag tests. |
see https://github.com/mozilla/sccache/blob/main/tests/system.rs for example |
bb88bf5
to
616dd8c
Compare
@sylvestre I've rebased to latest |
Bump |
sorry, i missed your comment. CI started! |
616dd8c
to
91b7c1c
Compare
@sylvestre Thanks for getting back to this PR. However, I'm still seeing "2 workflows awaiting approval" in GitHub. |
done |
@sylvestre There is currently not a single test in that file which exercises the Rust compiler. This is only done in I hope we're able to merge the few lines of this PR without requiring an entirely new test framework for the Rust compiler first. |
@ColinFinck we have proper Rustc testing: See: |
91b7c1c
to
7e96849
Compare
This has been implemented in a backward-compatible way:
--target
arguments specifying target names are still passed as arguments just like before.--target
arguments specifying a json file path have previously not been cached at all. The json file is now hashed like other external file dependencies.Fixes #2174