Fix: add file name in stack traces for compiled classes #1773
+37
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In interpreter mode, we always put the file name, but in compiled mode we do it only in case of
compilerEnv.isGenerateDebugInfo()
. I think that the interpreter's behavior is much more useful, so I changed the compiler to always include the file name.For an example of the difference, create two files:
one.js
and
two.js
:Then launch the shell passing
-version 200 -opt -1 -require one.js
to get the following, useful stack trace:But with
-opt 0
we get:which isn't as useful.