Shell: improve handling of unhandled promise rejection #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have changed the logging to log _all_ the exceptions, rather than just the first one. Also, we quit the process with non-zero status if we are evaluating a file (i.e. not in REPL mode) and there are any unhandled promise rejections. Co-authored-by: Satish Srinivasan <[email protected]>
gbrail
approved these changes
Dec 17, 2024
|
My only question is whether we think that someone will be broken by this change in a serious enough way to require us to add a command-line switch to not terminate on unhandled promise rejections. |
|
Honestly, rhino doesn't provide any API that returns a promise, such as |
|
OK -- I'm ok with this then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have changed the logging to log all the exceptions, rather than just the first one. Also, we quit the process with non-zero status if we are evaluating a file (i.e. not in REPL mode) and there are any unhandled promise rejections.
Example: create a file named
promise.js:If you launch this in both node and rhino, you will see that node exits with status 1, while rhino (before this PR) with status 0. With this change, rhino too exits with a non-zero status.