Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed printing tokens - added two missing cases #1675

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

andreabergia
Copy link
Contributor

@andreabergia andreabergia commented Oct 4, 2024

Teeny tiny PR 🙂

I suggest squashing this if accepted.

@rPraml
Copy link
Contributor

rPraml commented Oct 4, 2024

Maybe a small test for (i = 0; i <= LAST_TOKEN; i++) typeToName(i) would be also great here to prevent future mistakes ;)

@andreabergia
Copy link
Contributor Author

Maybe a small test for (i = 0; i <= LAST_TOKEN; i++) typeToName(i) would be also great here to prevent future mistakes ;)

You're right, I was lazy. And writing that test actually found out a few more tokens that were missing. 🙂

@rbri rbri merged commit 1477dfe into mozilla:master Oct 4, 2024
1 check passed
@rbri
Copy link
Collaborator

rbri commented Oct 4, 2024

thanks @andreabergia and @rPraml

@andreabergia andreabergia deleted the fix-token-printing branch October 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants